-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
total supply indexer #4863
Merged
Merged
total supply indexer #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avahowell
temporarily deployed
to
smoke-test
September 19, 2024 00:45 — with
GitHub Actions
Inactive
avahowell
had a problem deploying
to
smoke-test
September 19, 2024 01:16 — with
GitHub Actions
Error
avahowell
temporarily deployed
to
smoke-test
September 19, 2024 01:17 — with
GitHub Actions
Inactive
avahowell
temporarily deployed
to
smoke-test
September 20, 2024 19:36 — with
GitHub Actions
Inactive
avahowell
temporarily deployed
to
smoke-test
September 20, 2024 20:07 — with
GitHub Actions
Inactive
cronokirby
force-pushed
the
total-supply-pindexer
branch
from
September 20, 2024 22:32
47b3230
to
6b7c24d
Compare
cronokirby
temporarily deployed
to
smoke-test
September 20, 2024 22:32 — with
GitHub Actions
Inactive
cronokirby
temporarily deployed
to
smoke-test
September 20, 2024 23:03 — with
GitHub Actions
Inactive
This removes a lot of repeated logic around database accesses, and then also modularizes them to hide some of the implementation details in the rest of the file.
cronokirby
temporarily deployed
to
smoke-test
September 22, 2024 05:25 — with
GitHub Actions
Inactive
cronokirby
force-pushed
the
total-supply-pindexer
branch
from
September 22, 2024 06:57
61ab60c
to
37618d6
Compare
cronokirby
temporarily deployed
to
smoke-test
September 22, 2024 06:57 — with
GitHub Actions
Inactive
cronokirby
temporarily deployed
to
smoke-test
September 23, 2024 17:37 — with
GitHub Actions
Inactive
1 task
aubrika
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
aubrika
pushed a commit
that referenced
this pull request
Sep 26, 2024
## Describe your changes This adjusts the total supply indexer to account for whether or not value is locked in the dex, the auction component, or locked away after fees and arbitrage. This matters because a significant amount of the native token has been locked in arbitrage, so this affects the end result by about 50% (in terms of net new supply) Merge #4863 first. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > indexing only.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4835