Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: fold ibc stateful/historical check into their AHs #4317

Merged
merged 2 commits into from
May 7, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented May 4, 2024

Describe your changes

This is a mechanical refactor to fold the ibc/ics20 historical checks into a more visible place (their action handler implementations).

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Mechanical refactor

@erwanor erwanor added the A-IBC Area: IBC integration with Penumbra label May 4, 2024
@erwanor erwanor added this to the Sprint 6 milestone May 4, 2024
@erwanor erwanor requested a review from avahowell May 4, 2024 15:14
@erwanor erwanor self-assigned this May 4, 2024
@erwanor erwanor changed the title app: fold ibc stateful/historical check into their AH app: fold ibc stateful/historical check into their AHs May 4, 2024
Copy link
Contributor

@avahowell avahowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could have another check to verify that the outbound_ibc_enabled param is independent of the component being enabled, but this is much harder to test currently.

@erwanor erwanor merged commit 9a14f64 into main May 7, 2024
13 checks passed
@erwanor erwanor deleted the erwan/fold_historical_ibc_check branch May 7, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-IBC Area: IBC integration with Penumbra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants