auction: add GasCost impls for actions

[TalDerei]

Describe your changes

Add GasCost vectors for DA actions, addAction / ActionPlan skeletons, and make gas fee costs consistent with protobuf encodings (#3940)

Issue ticket number and link

References #4212

Checklist before requesting a review

• If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

[TalDerei]

@erwanor @zbuc should we make the DA fees be counted towards the block_space instead of the execution?

[zbuc]

@erwanor @zbuc should we make the DA fees be counted towards the block_space instead of the execution?

Do you mean the part multiplied by the step count? I think there is both a per-step block space and per-step execution time cost that should be accounted for. Doesn't each step incur a block space cost of storing liquidity positions?

[TalDerei]

@erwanor @zbuc should we make the DA fees be counted towards the block_space instead of the execution?

Do you mean the part multiplied by the step count? I think there is both a per-step block space and per-step execution time cost that should be accounted for. Doesn't each step incur a block space cost of storing liquidity positions?

yeah that's true, would the block_space therefore be something like proto encoding cost of action + (dutch_action_schedule.description.step_count * 8 bytes / step)?

[zbuc]

proto encoding cost of action + (dutch_action_schedule.description.step_count * 8 bytes / step)

I am operating under the assumption (that I am not 100% sure of) that every step, a LP will be closed (and withdrawn?) and a new one opened.

So I think it should be something like proto encoding cost of action + dutch_action_schedule.description.step_count * (PositionOpen block space cost + PositionClose block space cost + PositionWithdraw block space cost)

[hdevalence]

I don't think I follow — how does the chain opening and closing positions on its own add data to a future block?

[zbuc]

I don't think I follow — how does the chain opening and closing positions on its own add data to a future block?

I suppose it's not adding new Actions to the block and instead using only additional storage space in the JMT for the position data, and we don't account for JMT space usage in gas pricing.

[erwanor]

Requesting changes, but good to merge as soon as we have addressed the comments + green CI. I would be happy to pair on a second pass that makes the dependency between DA actions and the execution costs of position actions a little better (rather than having reminders in comments). But it seems good enough for now. Thanks for taking this on!