Enhance Nix packaging to build the crates and CometBFT #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is detected as a doctest because a code block is indented by 4 spaces, which is the same as the indentation of this bulleted list.
cratelyn
reviewed
Apr 2, 2024
There was a problem hiding this comment.
this was such a pleasure to review. thank you for doing this, @plaidfinch. this is really lovely work that will likely pay some dividends for ease of deployment, and it's almost certainly going to make my day-to-day life better too.
i have some assorted notes below, but the point about pinning to a specific rust toolchain version is the one i am most interested in answering. the other notes are mostly requests for comments; flake files feel a little magical sometimes, and it'd be good to be particularly explicit about intent/purpose.
conorsch
requested changes
Apr 2, 2024
cratelyn
approved these changes
Apr 2, 2024
this seems like it is likely to be spurious, but otherwise this all LGTM! i've kicked off another run of the |
conorsch
approved these changes
Apr 2, 2024
conorsch
added a commit
that referenced
this pull request
Apr 3, 2024
Docs builds broke after merge of [0], not because its settings were incompatible, but because its inclusion of a `rust-toolchain.toml` file busted the CI cache, and caused the `mdbook` dep to be freshly installed, rather than retrieved from cache. We don't version-lock mdbook and friends, and the latest version evidently bumped MSRV to 1.74, which is newer than what we set for MSRV. We should probably bump MSRV too, but I'll do that separately. This commit is to unbreak the docs builds. [0] #4145
1 task
conorsch
added a commit
that referenced
this pull request
Apr 3, 2024
Docs builds broke after merge of [0], not because its settings were incompatible, but because its inclusion of a `rust-toolchain.toml` file busted the CI cache, and caused the `mdbook` dep to be freshly installed, rather than retrieved from cache. We don't version-lock mdbook and friends, and the latest version evidently bumped MSRV to 1.74, which is newer than what we set for MSRV. We should probably bump MSRV too, but I'll do that separately. This commit is to unbreak the docs builds. [0] #4145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR enhances the Nix flake with additional derivations to build Penumbra's binaries and also CometBFT at the correctly compatible version.
Do
nix buildto build everything. Targets are:.#cometbft,.#pd,.#pcli, and.#pclientd.Do
nix developto jump into a shell with everything set up (requires flake support to be turned on in your nix install).Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: