fix(pd): minifront asset directory subpath #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jessepinho! |
|
Refs #4132 (comment) |
Follow-up to #4132, in which we updated the minifront assets but mistakenly with the wrong subdir nesting. This broke serving minifront from pd's gRPC endpoint, but our tests didn't catch that, so we only noticed when it hit preview. Added a test to the pd integration suite as a sanity check. Made sure to confirm that the test fails on current main, and passes with the asset fix included in this commit. Squashed and committed by @conorsch.
conorsch
force-pushed
the
jessepinho/frontend-zip-fix
branch
from
74ca6e3 to
837b6a3
Compare
|
Tacked on a test. LGTM! |
conorsch
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The previous .zip files had a subdirectory of the same name as the file itself. These updated files don't.
We should be creating zip files via a script — see penumbra-zone/web#857. This will avoid issues like this in the future.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: