Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex: move SwapExecutions to NV storage #4107

Merged
merged 2 commits into from
Mar 28, 2024
Merged

dex: move SwapExecutions to NV storage #4107

merged 2 commits into from
Mar 28, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Mar 26, 2024

Close #4084, please do not merge.

@erwanor erwanor added consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data A-dex Area: Relates to the dex labels Mar 26, 2024
@erwanor erwanor mentioned this pull request Mar 26, 2024
Closed
4 tasks
@erwanor erwanor requested review from hdevalence and zbuc March 26, 2024 18:37
@erwanor
Copy link
Member Author

erwanor commented Mar 26, 2024

This is ready to review and receive ACKs, but we should not merge it.

@erwanor erwanor self-assigned this Mar 26, 2024
@erwanor erwanor added this to the Sprint 3 milestone Mar 26, 2024
@erwanor erwanor marked this pull request as ready for review March 28, 2024 14:03
@erwanor erwanor requested a review from cratelyn March 28, 2024 16:47
@conorsch conorsch self-requested a review March 28, 2024 17:27
conorsch
conorsch approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This will shortly go out as part of v0.71.0, in which we ship a migration ship to perform a chain upgrade (#4087).

@conorsch conorsch mentioned this pull request Mar 28, 2024
Merged
1 task
@conorsch conorsch merged commit bc35aca into main Mar 28, 2024
7 checks passed
@conorsch conorsch deleted the erwan/4084_swap_execution_nv branch March 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

@hdevalence hdevalence Awaiting requested review from hdevalence

@zbuc zbuc Awaiting requested review from zbuc

@cratelyn cratelyn Awaiting requested review from cratelyn

Assignees

@erwanor erwanor

Labels
A-dex Area: Relates to the dex consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data
Projects
Penumbra
Archived in project
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Remove SwapExecutions from consensus state
2 participants
@erwanor @conorsch