Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibc: implement missing query RPCs #3572

Merged
merged 11 commits into from
Jan 5, 2024
Merged

ibc: implement missing query RPCs #3572

merged 11 commits into from
Jan 5, 2024

Conversation

avahowell
Copy link
Contributor

No description provided.

erwanor
erwanor approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conorsch conorsch mentioned this pull request Jan 4, 2024
Merged
@conorsch
Copy link
Contributor

conorsch commented Jan 5, 2024

Follow-up to #3531. This gets us most of the way toward IBC query coverage. Still to come are:

  • client_status
  • client_params
  • upgraded_client_state
  • upgraded_consensus_state

All of which still return "unimplemented" in this PR. We'll follow up on those when we need them.

@conorsch conorsch merged commit 72ca6d4 into main Jan 5, 2024
5 checks passed
@conorsch conorsch deleted the implement-remaining-ibc-grpcs branch January 5, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanor erwanor erwanor approved these changes

Assignees

@avahowell avahowell

Labels
None yet
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avahowell @conorsch @erwanor