Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auction: build penumbra-transaction support #4212

Closed
6 tasks done
Tracked by #4196
erwanor opened this issue Apr 15, 2024 · 1 comment
Closed
6 tasks done
Tracked by #4196

auction: build penumbra-transaction support #4212

erwanor opened this issue Apr 15, 2024 · 1 comment
Assignees
@erwanor @TalDerei
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Milestone
Sprint 4

Comments

@erwanor
Copy link
Member

erwanor commented Apr 15, 2024 •
edited by TalDerei
Loading

We need to implement IsAction and GasCosts prior to including the actions in penumbra-transaction:

Implementing IsAction

  • ActionDutchAuctionSchedule
  • ActionDutchAuctionEnd
  • ActionDutchAuctionWithdraw

Implementing GasCosts

  • ActionDutchAuctionSchedule
  • ActionDutchAuctionEnd
  • ActionDutchAuctionWithdraw

We should be particularly attentive to the value balance calculations and getting the gas cost vectors right.
@erwanor erwanor mentioned this issue Apr 15, 2024
Open
50 tasks
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 15, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 15, 2024
@erwanor erwanor added A-auction Area: Relates to the auction component _P-V1 Priority: slated for V1 release _P-high High priority and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 15, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 15, 2024
@erwanor erwanor moved this from Backlog to Todo in Penumbra Apr 15, 2024
@erwanor erwanor changed the title auction: transaction scaffolding , auction: build penumbra-transaction support Apr 15, 2024
@erwanor erwanor mentioned this issue Apr 16, 2024
Merged
1 task
@erwanor erwanor self-assigned this Apr 16, 2024
@TalDerei TalDerei self-assigned this Apr 16, 2024
erwanor added a commit that referenced this issue Apr 16, 2024
@erwanor
auction: define action balances (#4218)
ce5ba7e 
## Describe your changes

This PR:
- add `auctionnft`s to the asset registry
- augment `AuctionNft` with denom metadata
- implements `DutchAuctionDescription::id`
- implements value `balance` for each action
- implements computing the balance commitment for the withdraw action

## Issue ticket number and link
This is a prelude to #4212 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > This isn't connected to the rest of the app yet.
@TalDerei TalDerei mentioned this issue Apr 16, 2024
Merged
1 task
erwanor added a commit that referenced this issue Apr 17, 2024
@TalDerei @erwanor
auction: add GasCost impls for actions (#4223)
6c8d3e7 
## Describe your changes
Add `GasCost` vectors for DA actions, add`Action` / `ActionPlan`
skeletons, and make gas fee costs consistent with protobuf encodings
(#3940)

## Issue ticket number and link
References #4212

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

---------

Co-authored-by: Erwan Or <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra Apr 18, 2024
@erwanor erwanor reopened this Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Penumbra Apr 18, 2024
@erwanor
Copy link
Member Author

erwanor commented Apr 18, 2024

This isn't done yet, we need to finish integration in penumbra-transaction

@erwanor erwanor mentioned this issue Apr 18, 2024
Merged
1 task
erwanor added a commit that referenced this issue Apr 19, 2024
@erwanor
transaction: finalize auction integration (#4237)
971006e 
## Describe your changes

This PR:
- adds an action plan for withdrawing DA auctions
- plugs in `GasCost` and `IsAction` impls
- add basic TxV/TxP support/definitions

## Issue ticket number and link
Part of #4212 + #4219

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Consensus breaking
@erwanor erwanor closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

@TalDerei TalDerei

Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Milestone
Sprint 4
Development

No branches or pull requests
2 participants
@erwanor @TalDerei