Skip to content

Commit

Permalink
LQT: reimplementation with minimal in-memory state (#5049)
Browse files Browse the repository at this point in the history
## Describe your changes

This leans much more heavily on the database for indexing and ranking,
such that the only bit of in-memory storage is just the number of assets
that can be considered at most, based on the threshold.

Downside is that more of the logic exists as the sum of the behavior
across state keys,
and some tests were removed.

Adding some tests at the component level here which read and write
against temp storage would be useful ; perhaps mocking the
implementation of reward distribution or something.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:
  • Loading branch information
cronokirby authored Feb 4, 2025
1 parent 8cc540a commit 8b851a3
Show file tree
Hide file tree
Showing 5 changed files with 500 additions and 391 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ impl ActionHandler for ActionLiquidityTournamentVote {
power,
&self.body.rewards_recipient,
)
.await?;
.await;
Ok(())
}
}

This file was deleted.

Loading

0 comments on commit 8b851a3

Please sign in to comment.