Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve data requests for trading pairs #356

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

VanishMax
Copy link
Contributor

Perfecting the explore page:

  1. Implement search feature – user enters the string value, frontend sends the request with 400ms debounce, backend computes AssetIds, Pindexer filters by this array
  2. Move sorting logic to SQL completely, this unlocks correct pagination
  3. Move filtering logic to SQL completely (by volume != 0 OR liquidity != 0)
  4. Change inner join with candles table to the left join, so 5 more active assets are not filtered out
  5. Display info if no pairs are found
explore.mp4

@VanishMax VanishMax requested a review from a team February 6, 2025 09:21
@VanishMax VanishMax self-assigned this Feb 6, 2025
Copy link
Contributor

@JasonMHasperhoven JasonMHasperhoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VanishMax VanishMax merged commit fa7b6eb into main Feb 6, 2025
3 checks passed
@VanishMax VanishMax deleted the feat/improve-summaries-request branch February 6, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants