Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): ditch corepack in containerfile #341

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Feb 3, 2025

The deploy pipeline was failing on container builds (across the PL frontend repos) due to upstream breakage in corepack [0]. This changes matches changes in e.g. [1].

[0] nodejs/corepack#612
[1] penumbra-zone/penumbers#19

The deploy pipeline was failing on container builds (across the PL
frontend repos) due to upstream breakage in corepack [0].
This changes matches changes in e.g. [1].

[0] nodejs/corepack#612
[1] penumbra-zone/penumbers#19
@conorsch conorsch requested a review from TalDerei February 3, 2025 19:44
@conorsch
Copy link
Contributor Author

conorsch commented Feb 3, 2025

Confirmed that this change fixes the deploy pipeline by running the pipeline ad-hoc against this branch, here: https://github.com/penumbra-zone/dex-explorer/actions/runs/13121552748

conorsch added a commit to penumbra-zone/cuiloa that referenced this pull request Feb 3, 2025
The deploy pipeline was failing on container builds (across the PL
frontend repos) due to upstream breakage in corepack [0].
This changes matches changes in e.g. [1], [2].

[0] nodejs/corepack#612
[1] penumbra-zone/penumbers#19
[2] penumbra-zone/dex-explorer#341
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

conorsch added a commit to penumbra-zone/cuiloa that referenced this pull request Feb 3, 2025
The deploy pipeline was failing on container builds (across the PL
frontend repos) due to upstream breakage in corepack [0].
This changes matches changes in e.g. [1], [2].

[0] nodejs/corepack#612
[1] penumbra-zone/penumbers#19
[2] penumbra-zone/dex-explorer#341
@conorsch conorsch merged commit 67f58d9 into main Feb 3, 2025
6 checks passed
@conorsch conorsch deleted the fix-container-builds branch February 3, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants