feat(#328): my trades implementation #337

VanishMax · 2025-01-30T11:20:37Z

Closes #328 #327

Waits for penumbra-zone/web#2019 and then Prax release

Considerations of this PR:

/api/my-executions is a POST method that accepts a possibly large body + AssetIds instead of symbols to not search for it in the registry and save time
useLatestSwaps hook requests data in a pipeline, from Prax first, then from Pindexer
If Prax returned no data or the amount of swaps in Prax is the same as previously requested data from Pindexer, the backend request to /api/my-executions will not be made to save time
When new swap is made, refetches Pindexer data each 5 seconds until the swap is propagated from there
The table has loading, empty, not connected states

my-trades.mp4

Before running: install local version of the protobuf package

TalDerei

encountering the following error after linking to the protobuf package locally

VanishMax · 2025-02-04T09:46:52Z

src/pages/trade/ui/trades/my-trades.tsx

+  // TODO: filter out irrelevant swaps from pindexer
+  const { data, isLoading, error } = useLatestSwaps(subaccount);


todo: pindexer might return 2+ swaps per asset pair and a block height. Only one swap must be filtered out to match the user's swap. Might need some help do to 2+ swaps in the same block

TalDerei

I think it’s almost there! I left some comments with observations specific to my wallet

src/pages/trade/api/latest-swaps.ts

TalDerei · 2025-02-05T04:17:57Z

src/pages/trade/api/latest-swaps.ts

+    return [];
+  }
+
+  // Two requests to get swaps in both directions: buy and sell


ACK – rendering both swap directions of the pair.

src/shared/database/index.ts

TalDerei · 2025-02-05T04:50:59Z

src/shared/api/server/my-executions.ts

+ * Combines the list of pair:height combinations into a list of unique pairs with all heights in a merged array.
+ * This transformation is needed to reduce the amount of database queries.
+ */
+const adaptBody = (body: MyExecutionsRequestBody[]): ExecutionCollection[] => {


ACK – taking the mapped swap objects and transforming them into a form more amenable for efficient pindexer querying.

TalDerei · 2025-02-05T04:56:30Z

src/shared/api/server/my-executions.ts

+  const [registry, sellStream, buyStream] = await Promise.all([
+    registryClient.remote.get(chainId),
+    Promise.all(data.map(data => pindexer.myExecutions(data.base, data.quote, data.heights))),
+    Promise.all(data.map(data => pindexer.myExecutions(data.quote, data.base, data.heights))),
+  ]);


comment:

myTradesQuery is returning 52 results for UM <> USDC pair (out of 64 swaps stored in IndexedDB).

myExecutionsQuery then sends the mapped swap objects to the server endpoint (/api/my-executions).

The server then queries pindexer which filters these results down to only 5 swaps, which isn't correct. I think this is pointing to an incorrect SQL query.

@TalDerei this might be related to the issue with pindexer not storing (or losing) some swaps, discussed in the protocol chat. Same happens to me with old swaps, the new ones should work fine

@TalDerei this might be related to the issue with pindexer not storing (or losing) some swaps, discussed in the protocol chat. Same happens to me with old swaps, the new ones should work fine

I see, linked this discussion in that thread

src/shared/api/server/my-executions.ts

VanishMax · 2025-02-05T11:31:12Z

@TalDerei I did a major refactor to the SQL query. Now it sends only 1 request to Pindexer instead of multiple ones and uses only Postgres features to perform the checks:

Creates a virtual table with latestSwaps data, duplicating data for sell-buy directions in advance
Merges this data with swap executions from Pindexer

An important recent change: now the merge happens not only by pair and height, but also by the amount field that is different for buy-sell directions. This makes sure we only receive personal swaps, not many random swaps on a height as before.

TalDerei · 2025-02-05T19:05:19Z

An important recent change: now the merge happens not only by pair and height, but also by the amount field that is different for buy-sell directions.

reviewed the diff, and I think these changes generally make sense to me. I'll spend some time investigating our missing data issue.

update: I personally haven't found the culprit, and pindexer is now returning zero swap information for me.

TalDerei · 2025-02-07T01:25:34Z

@VanishMax what happens if the user has more swaps than we can display in the page? will it overflow the rendering?

VanishMax · 2025-02-07T09:44:49Z

@TalDerei good point, I added the limit of 10 swaps, can be adjusted any time. Also, sorted by time desc

VanishMax · 2025-02-07T10:11:32Z

update: I personally haven't found the culprit, and pindexer is now returning zero swap information for me.

found an issue with amount filtering – should've filtered by batch_input instead of input. Do you have trades now?

erwanor · 2025-02-07T13:40:10Z

Thanks, will do a round of review as well

TalDerei · 2025-02-10T16:05:11Z

found an issue with amount filtering – should've filtered by batch_input instead of input. Do you have trades now?

only seeing a single trade on my end coming out of pindexer – will review the recent changes.

TalDerei

this seems to be rendering recent trades, and we can circle back and iterate on why historical swaps aren't displayed. great work 👍

erwanor · 2025-02-11T15:13:53Z

We will want to harden the virtual table query, and carve out some time to iron out the kinks as they come up. Nice work

feat(#328): my trades implementation

2765d0d

VanishMax requested a review from TalDerei January 30, 2025 11:20

VanishMax self-assigned this Jan 30, 2025

VanishMax marked this pull request as draft January 30, 2025 16:35

TalDerei reviewed Jan 31, 2025

View reviewed changes

VanishMax added 5 commits February 3, 2025 14:03

feat: implement my-executions POST request

b387533

fix: prepare data for my trades

f24e89b

fix: data requests

d571d20

feat: finish my trades section

183dddd

todo: add todos

05ecedf

VanishMax requested a review from a team February 4, 2025 09:14

VanishMax marked this pull request as ready for review February 4, 2025 09:19

VanishMax commented Feb 4, 2025

View reviewed changes

VanishMax requested a review from TalDerei February 4, 2025 17:02

TalDerei reviewed Feb 5, 2025

View reviewed changes

VanishMax mentioned this pull request Feb 5, 2025

pindexer: data loss in the dex_ex_batch_swap_traces table penumbra-zone/penumbra#5054

Open

VanishMax added 4 commits February 5, 2025 12:33

chore: update dependencies

9f2e53f

fix: pr review comments

8b4c4c5

docs: update comments about my-executions

4b98816

feat: improve myTrades pindexer query

ca5d9b1

VanishMax requested a review from TalDerei February 5, 2025 11:26

fix: limit the amount of returned trades

c2477ba

fix: filter by batch_amount instead of input

7413b24

erwanor self-requested a review February 7, 2025 13:39

TalDerei approved these changes Feb 10, 2025

View reviewed changes

erwanor merged commit a1b1fa9 into main Feb 11, 2025
3 checks passed

erwanor deleted the feat/#328-my-trades branch February 11, 2025 15:13

TalDerei mentioned this pull request Feb 12, 2025

explorer: pull rich swap execution data from pindexer #327

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(#328): my trades implementation #337

feat(#328): my trades implementation #337

VanishMax commented Jan 30, 2025 •

edited

Loading

TalDerei left a comment •

edited

Loading

VanishMax Feb 4, 2025

TalDerei left a comment

TalDerei Feb 5, 2025

TalDerei Feb 5, 2025

TalDerei Feb 5, 2025

VanishMax Feb 5, 2025

TalDerei Feb 5, 2025

VanishMax commented Feb 5, 2025

TalDerei commented Feb 5, 2025 •

edited

Loading

TalDerei commented Feb 7, 2025

VanishMax commented Feb 7, 2025

VanishMax commented Feb 7, 2025

erwanor commented Feb 7, 2025

TalDerei commented Feb 10, 2025 •

edited

Loading

TalDerei left a comment •

edited

Loading

erwanor commented Feb 11, 2025

		// TODO: filter out irrelevant swaps from pindexer
		const { data, isLoading, error } = useLatestSwaps(subaccount);

feat(#328): my trades implementation #337

feat(#328): my trades implementation #337

Conversation

VanishMax commented Jan 30, 2025 • edited Loading

TalDerei left a comment • edited Loading

Choose a reason for hiding this comment

VanishMax Feb 4, 2025

Choose a reason for hiding this comment

TalDerei left a comment

Choose a reason for hiding this comment

TalDerei Feb 5, 2025

Choose a reason for hiding this comment

TalDerei Feb 5, 2025

Choose a reason for hiding this comment

TalDerei Feb 5, 2025

Choose a reason for hiding this comment

VanishMax Feb 5, 2025

Choose a reason for hiding this comment

TalDerei Feb 5, 2025

Choose a reason for hiding this comment

VanishMax commented Feb 5, 2025

TalDerei commented Feb 5, 2025 • edited Loading

TalDerei commented Feb 7, 2025

VanishMax commented Feb 7, 2025

VanishMax commented Feb 7, 2025

erwanor commented Feb 7, 2025

TalDerei commented Feb 10, 2025 • edited Loading

TalDerei left a comment • edited Loading

Choose a reason for hiding this comment

erwanor commented Feb 11, 2025

VanishMax commented Jan 30, 2025 •

edited

Loading

TalDerei left a comment •

edited

Loading

TalDerei commented Feb 5, 2025 •

edited

Loading

TalDerei commented Feb 10, 2025 •

edited

Loading

TalDerei left a comment •

edited

Loading