Fix linting for market #340

minghansun1 · 2025-02-17T06:08:13Z

No description provided.

… in views to use a more abstract filtering method

…but should work

codecov · 2025-02-17T06:10:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (b44826e) to head (806e4c3).
Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #340       +/-   ##
===========================================
+ Coverage   78.22%   88.89%   +10.67%     
===========================================
  Files          73       73               
  Lines        3128     3171       +43     
===========================================
+ Hits         2447     2819      +372     
+ Misses        681      352      -329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dr-Jess

NO THIS IS TERRIBLE
jk looks good :)

vcai122 and others added 30 commits October 21, 2024 18:19

create market app and copy over sublet files

b726fe8

add previous sublet stuff back

124f751

fix isort

316e43a

Updated models.py

502b49c

updated models and changed permissions

318db5c

renamed everything from sublet to market, added app to installed_apps

b76fc05

Updated serializers and views to support creating a sublet through item

da3fbe8

Added serializer level validation for category+sublet

9b66650

Addressed unaddressed feedback and feedback from today

24dbfad

two routes for Item/Sublet, made sure other features worked too

4771b60

Removed Read Serializer, Refactored list function for Item and Sublet…

846697f

… in views to use a more abstract filtering method

used code formatter

c4610ba

fixed most of Vincent's comments

2e66213

fixed all comments except last one

306f986

Addressed all comments

3e2c8c1

addressed all concerns

c52049e

deleted unused apply_filters function

8efe703

linted

15274d4

added 7 tests for create andupdate

8b32eb1

work in progress test

9bcafc0

Finished most tests for market, need to write a few tests for images …

a8a0ca8

…but should work

added tests for images

b0253ae

linted

b114a73

fixed hard coded/redundant stuff I talked about with Vincent

fc52d6a

fixed a small inefficiency

4f0db1f

fixed tests

d62e85d

linted

343f94d

updated test time limit

49f2ae4

updated test time limit

9889f15

lint

b74ed96

minghansun1 and others added 10 commits February 16, 2025 20:48

fixed autoincrement

b754187

lint

c9bd1fd

black

233e802

debug

308a2a6

reset everything at start of each test

002acf6

removed reset of tag and category

6a8260d

fixed get_items test case

bb542d4

lint

e4e7496

Merge branch 'master' into minghan-market-two-routes

de3fef6

linted

fefc467

minghansun1 requested a review from vcai122 February 17, 2025 06:10

minghansun1 added 3 commits February 17, 2025 01:12

Merge branch 'master' into fix_linting_for_market

dcc9e8a

Update serializers.py

138edcd

Update serializers.py

806e4c3

dr-Jess approved these changes Feb 17, 2025

View reviewed changes

minghansun1 merged commit f13f141 into master Feb 17, 2025
9 checks passed

minghansun1 deleted the fix_linting_for_market branch February 17, 2025 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linting for market #340

Fix linting for market #340

minghansun1 commented Feb 17, 2025

codecov bot commented Feb 17, 2025 •

edited

Loading

dr-Jess left a comment

Fix linting for market #340

Fix linting for market #340

Conversation

minghansun1 commented Feb 17, 2025

codecov bot commented Feb 17, 2025 • edited Loading

Codecov Report

dr-Jess left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 17, 2025 •

edited

Loading