Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android, Extract out Notif API Logic #325

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Conversation

vcai122
Copy link
Contributor

@vcai122 vcai122 commented Nov 17, 2024

…make it always be celery task

@vcai122 vcai122 requested a review from tuneerroy November 17, 2024 07:52
Copy link
Contributor

@tuneerroy tuneerroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tuneerroy
Copy link
Contributor

Thoughts on writing Celery tests? :)

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 62.63736% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (d1044c2) to head (4821d03).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
backend/user/notifications.py 66.66% 28 Missing ⚠️
backend/user/views.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   90.23%   89.05%   -1.18%     
==========================================
  Files          66       66              
  Lines        2684     2742      +58     
==========================================
+ Hits         2422     2442      +20     
- Misses        262      300      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from revamp-notifications to master November 17, 2024 17:09
@vcai122 vcai122 merged commit b1a8bfa into master Nov 17, 2024
7 of 9 checks passed
@vcai122 vcai122 deleted the android-notifications branch November 17, 2024 18:52
Copy link

sentry-io bot commented Nov 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'IOSNotificationWrapper' object has no attribute 'client' notifications.ios_send_dev_notification View Issue
  • ‼️ SSLEOFError: EOF occurred in violation of protocol (_ssl.c:2423) notifications.ios_send_dev_notification View Issue
  • ‼️ ConnectionResetError notifications.ios_send_notification View Issue
  • ‼️ SSLError: [SSL: BAD_LENGTH] bad length (_ssl.c:2423) notifications.ios_send_notification View Issue
  • ‼️ TypeError: NotificationWrapper.send_notification() missing 1 required positional argument: 'urgent' notifications.ios_send_dev_notification View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants