Break CRUD routes #703
Open
Break CRUD routes #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-agua
requested changes
Feb 16, 2025
backend/courses/models.py
Outdated
|
|
||
| associated_break = models.ForeignKey( | ||
| "plan.Break", | ||
| null=True, | ||
| on_delete=models.CASCADE, | ||
| related_name="meetings", | ||
| help_text="The Section object to which this class meeting belongs.", |
backend/courses/models.py
Outdated
| @@ -1180,6 +1190,19 @@ class Meeting(models.Model): | |||
| ), | |||
| ) | |||
|
|
|||
| def clean(self): | |||
There was a problem hiding this comment.
Consider using Django's built in CONSTRAINT libraries. It is probably more natural to SQL
https://docs.djangoproject.com/en/5.1/ref/models/constraints/
el-agua
requested changes
Feb 23, 2025
backend/plan/views.py
Outdated
| context = super().get_serializer_context() | ||
| include_location_str = "False" | ||
| # TODO: figure out how we want to do locations. | ||
| context.update({"include_location": eval(include_location_str)}) |
There was a problem hiding this comment.
Lets try not to use eval, if locations are not considered in this v1 version, we can comment out?
|
I think work now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a break view set so that someone can create and update breaks on PCP in the backend.
This is a simple view set with CRUD routes that should let a user add breaks to their schedule in penn course plan.
I wrote test cases in test_schedule.py.
Some design decisions: