Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 18 Docker image and CI updates #522

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Node.js 18 Docker image and CI updates #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79cff14
CI: move away from an Ubuntu version variable in GH Actions
orangejulius Nov 26, 2024
04949e6
CI: remove EOL Node.js 12/16/18
orangejulius Nov 26, 2024
72f187b
CI: Test Node.js versions supported by this repo
orangejulius Nov 26, 2024
77816ea
CI: use standard Github Action templates
orangejulius Nov 26, 2024
0d47924
feat(docker): Upgrade to Node.js 18 Docker baseimage
orangejulius Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@ jobs:
strategy:
matrix:
os:
- ${{ vars.UBUNTU_VERSION }}
node-version:
- 12.x
- 14.x
- 16.x
- 18.x
- ubuntu-22.04
node-version: [ 18.x, 20.x ]
steps:
- uses: actions/checkout@v4
- name: 'Install node.js ${{ matrix.node-version }}'
Expand All @@ -20,5 +16,6 @@ jobs:
node-version: '${{ matrix.node-version }}'
- name: Run unit tests
run: |
[[ -f ./bin/ci-setup ]] && ./bin/ci-setup
npm install
npm run ci
6 changes: 3 additions & 3 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ jobs:
npm-publish:
needs: unit-tests
if: github.ref == 'refs/heads/master' && needs.unit-tests.result == 'success'
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: Run semantic-release
env:
GH_TOKEN: ${{ secrets.GH_SEMANTIC_RELEASE_TOKEN }}
Expand All @@ -26,7 +26,7 @@ jobs:
# note: github actions won't run a job if you don't call one of the status check functions, so `always()` is called since it evalutes to `true`
if: ${{ always() && needs.unit-tests.result == 'success' && (needs.npm-publish.result == 'success' || needs.npm-publish.result == 'skipped') }}
needs: [unit-tests, npm-publish]
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Build Docker images
Expand Down