Fix date-based restart pruning breaking on empty restart dirs #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanheerdegen
previously approved these changes
Oct 31, 2023
|
Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-11-01 05:36:34 UTC |
…nd mom6 drivers - add a test for date-based restart pruning ignoring empty restart directories
jo-basevi
force-pushed
the
375-date-based-restart-MOM-mixin
branch
from
6044072 to
ea9cbef
Compare
aidanheerdegen
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue described in #375, Closes #375
Instead of raising an exception when restart file can't be found, a warning is printed and the restart is ignored from date-based restart pruning.
Also, moved code for restart file parsing for
ocean_solo.resto a mixin mom class. This mixin class is then pulled into themomandmom6model drivers.