deployment to test API #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
reviewed
Jun 5, 2024
dev/docker-compose.test.yaml
Outdated
There was a problem hiding this comment.
any reason why this is a new file, rather than a change in dev/docker-compose.yaml?
There was a problem hiding this comment.
For testing I wanted to have an empty database which is maybe not so practical for deploying SciCat for actual development.
|
I added an additional service called "test_be_next" and not just a profile (contrary to what we discussed @minottic ). The reason is that for testing another environment file is required. |
|
thanks. Yes, I think it's unavoidable. I'll propose a small change on Monday, to see if we can reuse part of the existing .env, but looks good otherwise. Thanks! |
minottic
reviewed
Jun 10, 2024
|
I updated the docker-compose as you asked. |
minottic
reviewed
Jun 26, 2024
minottic
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mounts functional Accounts and assigns respective groups permission to test the API