-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(text-input): form submission #2647
Conversation
🦋 Changeset detectedLatest commit: 3ec82a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@bennypowers Should a form still be submitted if the I added this code to the demo <fieldset>
<form id="pf-form">
<legend>Text Input</legend>
<label for="input">Input</label>
<pf-text-input id="input" required></pf-text-input>
</form>
</fieldset>
<script type="module">
import '@patternfly/elements/pf-text-input/pf-text-input.js';
const pfForm = document.querySelector('#pf-form');
pfForm.addEventListener('submit', event => {
event.preventDefault();
console.log('pf-form submitted');
});
</script>
<link rel="stylesheet" href="demo.css"> What I'm seeing is that event though the |
@bennypowers Very nice. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low-tuned Guitars Thrash Metal 🤘
What I did