Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New airplane models merged from Germanwings change #274

Merged
merged 23 commits into from
Feb 23, 2020

Conversation

patsonluk
Copy link
Owner

@patsonluk patsonluk commented Feb 22, 2020

Description

Merged the changes from #266 to this. Better to have a PR to compare only the airplane changes

patsonluk and others added 8 commits February 1, 2020 09:59
Added and expanded/changed airplanes, stats. range, speed, capacity, etc. researched from Wikipedia. I had to play around with the prices and fuel. Feel free to suggest any more adjustments.
Added all missing Airplane pictures.
…nto issue273-new-airplane-models

# Conflicts:
#	airline-data/src/main/scala/com/patson/model/airplane/Model.scala
@patsonluk patsonluk changed the base branch from master to issue271-airplane-family February 22, 2020 20:50
@patsonluk
Copy link
Owner Author

patsonluk commented Feb 22, 2020

@Germanwings Thank you for the great work! The data were very clean and consistent! And I <3 then extra manufacturers!

Now I have merged the change with minor change to model spelling and to avoid replacing the old airplanes. I have also assigned the family to each model (mostly according to your change, some extra modifications see below)

I have NOT YET adjust any parameters and I have several things I would like to bring to ur attention/need your input:

  1. I noticed you added some of the airplanes that overlap with the existing ones with different values. Though I believe ur stats are likely more accurate, we probably cannot change the existing model due to compatibility issue. I have kept the existing model unchanged but that might mean that we will need to adjust a bit on the airplane stats you provided on capacity
  2. We will need to go through the list (now it's sorted on capacity) and adjust the parameters (price, capacity, fuel burn etc). I am thinking the the ER version is supposed to be either a bit less fuel efficient or slightly lower capacity. I noticed that u have already put a slightly higher price tag, which makes sense, but i think cap and fuel efficient should have a very slight diff too. This current commit (9fd24d8 )contains no parameter adjustment. I will do a first pass of adjustments, then i can compare the 2 and discuss further
  3. I have split the 737 family a bit further as that family is simply a bit too large

Many thanks again!

@patsonluk
Copy link
Owner Author

First pass of adjustments @Germanwings 9e7336f

@Germanwings
Copy link
Contributor

Sure I am fine with you doing some changes and I understand that current stats can't be changed rn, thus we could hold those changes back for v.2 so that every airplane matches. Feel free to perform some adjustments. For the ER Versions, it depends on the planes and I looked that up individually. Some loose seats, some cost more, some do both it really depends.

@Germanwings
Copy link
Contributor

737, I would then just create a 737-classic family until the -700 and then a 737-NG Family instead.

patsonluk added 8 commits February 23, 2020 09:49
@patsonluk patsonluk merged commit 749d740 into issue271-airplane-family Feb 23, 2020
@patsonluk patsonluk deleted the issue273-new-airplane-models branch February 23, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants