-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New airplane models merged from Germanwings change #274
New airplane models merged from Germanwings change #274
Conversation
Added and expanded/changed airplanes, stats. range, speed, capacity, etc. researched from Wikipedia. I had to play around with the prices and fuel. Feel free to suggest any more adjustments.
Added all missing Airplane pictures.
…nto issue273-new-airplane-models # Conflicts: # airline-data/src/main/scala/com/patson/model/airplane/Model.scala
Assigned Family
@Germanwings Thank you for the great work! The data were very clean and consistent! And I <3 then extra manufacturers! Now I have merged the change with minor change to model spelling and to avoid replacing the old airplanes. I have also assigned the family to each model (mostly according to your change, some extra modifications see below) I have NOT YET adjust any parameters and I have several things I would like to bring to ur attention/need your input:
Many thanks again! |
First pass of adjustments @Germanwings 9e7336f |
Sure I am fine with you doing some changes and I understand that current stats can't be changed rn, thus we could hold those changes back for v.2 so that every airplane matches. Feel free to perform some adjustments. For the ER Versions, it depends on the planes and I looked that up individually. Some loose seats, some cost more, some do both it really depends. |
737, I would then just create a 737-classic family until the -700 and then a 737-NG Family instead. |
…ice, capacity etc) Changed sell price calculation - now base on market price (with model discount)
…dels # Conflicts: # airline-data/src/main/scala/com/patson/AirplaneModelSimulation.scala
Description
Merged the changes from #266 to this. Better to have a PR to compare only the airplane changes