Merge pull request #81 from AutoSponge/support-cached-nodes

provides simple mechanism to support using cached nodes
patrick-steele-idem · Sep 6, 2016 · 3d4be15 · 3d4be15
2 parents 2a60451 + df2a69f
commit 3d4be15
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -372,6 +372,10 @@ function morphdom(fromNode, toNode, options) {
             delete fromNodesLookup[toElKey];
         }
 
+        if (toNode.isSameNode && toNode.isSameNode(fromNode)) {
+            return;
+        }
+
         if (!childrenOnly) {
             if (onBeforeElUpdated(fromEl, toEl) === false) {
                 return;
@@ -399,6 +403,10 @@ function morphdom(fromNode, toNode, options) {
                 curToNodeKey = getNodeKey(curToNodeChild);
 
                 while (curFromNodeChild) {
+                    if (curToNodeChild.isSameNode && curToNodeChild.isSameNode(curFromNodeChild)) {
+                        return;
+                    }
+
                     curFromNodeKey = getNodeKey(curFromNodeChild);
                     fromNextSibling = curFromNodeChild.nextSibling;
 

diff --git a/test/browser/test.js b/test/browser/test.js
@@ -726,6 +726,23 @@ function addTests() {
             expect(el1.querySelector('#skipMeChild') != null).to.equal(true);
         });
 
+        it('should use isSameNode to allow reference proxies', function() {
+            var el1 = document.createElement('div');
+            el1.innerHTML = 'stay gold';
+            var el2 = document.createElement('div');
+            el2.innerHTML = 'ponyboy';
+            el2.isSameNode = function (el) {return el.isSameNode(el1)};
+            morphdom(el1, el2);
+            expect(el1.innerHTML).to.equal('stay gold');
+
+            var containEl1 = document.createElement('div');
+            containEl1.appendChild(el1);
+            var containEl2 = document.createElement('div');
+            containEl2.appendChild(el2);
+            morphdom(containEl1, containEl2);
+            expect(el1.innerHTML).to.equal('stay gold');
+        });
+
         // xit('should reuse DOM element with matching ID and class name (2)', function() {
         //     // NOTE: This test is currently failing. We need to improve the special case code
         //     //       for handling incompatible root nodes.