Fix breaking changes introduced in JAX 0.4.36. #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-kidger
force-pushed
the
jax-breakage-fixes
branch
from
ad09db8 to
f09bacd
Compare
See: - jax-ml/jax#25289 - patrick-kidger/diffrax#532 The problem was that batching has now become a dynamic trace, and our batching rules were not set up to handle the case that every batch axis is `not_mapped`.
We still have one in `filter_jvp` that might need some later resolution, as JAX now has a comment indicating that they intend to remove this function. `if_mapped` was never documented (and frankly not that useful either) so I'm treating its removal here as a non-breaking change.
patrick-kidger
force-pushed
the
jax-breakage-fixes
branch
from
db2bc7e to
c6c1a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
vmaperror due to commitc36e1f7jax-ml/jax#25289The problem was that batching has now become a dynamic trace, and our batching rules were not set up to handle the case that every batch axis is
not_mapped.