Add RMSNorm #629
Merged
Add RMSNorm #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| [this paper](https://browse.arxiv.org/abs/2307.14995). `\beta` is an optional bias | ||
| term. | ||
|
|
||
| ??? cite |
There was a problem hiding this comment.
Nit: this will need a new line here in order to render correctly in the docs.
i.e.
??? cite
fooThere was a problem hiding this comment.
Also, whilst we're here -- maybe worth emphasising that use_{weight,bias}=False is the default.
(Should we keep it as the default? I appreciate that's maybe more useful, but it's inconsistent with the other normalisation layers. WDYT?)
There was a problem hiding this comment.
Thanks for raising the point about the defaults. I feel its good to maintain consistency, especially with LayerNorm. Changed defaults to on.
|
Alright, LGTM! Thank you for tidying this one up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #545 addressing reviewers' comments.