Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create py.typed marker file to mark the code as typed. #547

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

vidhanio
Copy link
Contributor

@vidhanio vidhanio commented Oct 9, 2023

without this file, mypy complains:

src/***/__main__.py:4: error: Skipping analyzing "equinox": module is installed, but missing library stubs or py.typed marker  [import]
src/***/__main__.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

adding this file fixes the error.

@patrick-kidger patrick-kidger merged commit bcd39db into patrick-kidger:main Oct 9, 2023
2 checks passed
@patrick-kidger
Copy link
Owner

Whoops - LGTM! Thank you for the contribution.

By the way, I'd recommend trying out pyright, which is usually faster / more accurate than mypy.

@vidhanio
Copy link
Contributor Author

pylance/pyright also had a similar error, i just assumed mypy errors are more general. i saw that pyright is used in ci in this project, but local development doesn't require a py.typed, unlike when you import it as an external package.

thank you for merging! this library looks great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants