Allow script-location property to be a list #67
Conversation
Co-authored-by: Steve Todorov <[email protected]>
|
Hi @rbleuse, thanks a lot for the PR and sorry for my late response. I will look at it on the weekend. The holidays should finally give me the time to take care of this. |
| * @return The locations of the migration scripts. Never null. | ||
| */ | ||
| public List<String> getScriptLocations() { | ||
| return scriptLocations; |
There was a problem hiding this comment.
I would suggest to return Collections.unmodifiableList(scriptLocations) to prevent any tempering with the list.
There was a problem hiding this comment.
Sure, thanks for the suggestion
| .version("3.11.12") | ||
| .build(); | ||
| cassandra.start(); | ||
| LOGGER.warn("cassandra started successfully"); |
There was a problem hiding this comment.
Can we remove these log messages? I assume they were for testing but I don't think that tests need to log messages, especially not at level warning.
| .addConfigProperty("enable_user_defined_functions", true) | ||
| .build(); | ||
| cassandra.start(); | ||
| LOGGER.warn("cassandra started successfully"); |
| @@ -28,6 +31,11 @@ public class JarLocationScannerTest { | |||
| private static File jarFile; | |||
| private static URI jarUri; | |||
|
|
|||
| @Before | |||
| public void windowsOnly() { | |||
| Assume.assumeFalse(isWindows()); | |||
There was a problem hiding this comment.
I think it makes sense to provide a message here. Just failing without explanation is kind of rude :)
There was a problem hiding this comment.
Thanks for the suggestion. One thing is it doesn't fail, it just doesn't run tests if the Assume is not satisfied.
It's kind of a conditional @Ignore ;)
|
I fixed according to your comments. Please check |
Similar to Flyway, we can have the possibility to set multiple location for script paths (https://flywaydb.org/documentation/configuration/parameters/locations)
Job done :
script-locationin spring properties for backward compatibilityscriptPathas a String for backward compatibility in theMigrationRepositoryclassWe can choose which cassandra-unit version to use for tests, just one note is that cassandra itself has drop support for windows since early 4.0 beta, so if we want to enable testing cassandra 4+ on all environment, the only solution will be to use Testcontainers