Rename PrivateAttribution.aggregators to aggregationServices #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
commented
Jan 14, 2025
| @@ -603,7 +603,7 @@ The arguments to <a method for=PrivateAttribution>measureConversion()</a> are as | |||
| <dt><dfn>aggregator</dfn></dt> | |||
There was a problem hiding this comment.
It's unclear to me if we want to change the terminology here as well.
|
I think @martinthomson had made this change in the other direction ( |
I don't have a strong feeling either way, but agree on resolving the inconsistency. |
|
Let's resolve that question in discussion on the issue (which I'll put on the agenda for our next meeting). |
To match the surrounding prose, and for consistency with the names of the corresponding IDL types. Fixes patcg#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the surrounding prose, and for consistency with the names of the corresponding IDL types.
Fixes #66