Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Extra Containers Support #91

Merged

Conversation

crhuber
Copy link
Contributor

@crhuber crhuber commented Sep 19, 2024

Adds support for extra containers to be added to the deployment. This is useful where teams have a need to add a sidecar container alongside the main application.

For example to use GCP CloudSQL you need to use cloudsqlproxy.
Usage would be like so

  extraContainers:
    - name: cloud-sql-proxy
      image: gcr.io/cloud-sql-connectors/cloud-sql-proxy:2.1.2-alpine
      imagePullPolicy: IfNotPresent
      command:
        - "./cloud-sql-proxy"
        - "foo:europe-west1:bar"
        - "--port"
        - "5432"
        - "--structured-logs"
      ports:
        - containerPort: 5432
          protocol: TCP
        runAsNonRoot: true
      resources:
        limits:
          memory: 48Mi
        requests:
          cpu: 100m
          memory: 32Mi

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@crhuber
Copy link
Contributor Author

crhuber commented Sep 30, 2024

Hey @dlen any chance of a review here please? thanks

@dlen
Copy link
Member

dlen commented Sep 30, 2024

hi @crhuber!

Thanks for your submission it is really appreciated! I'll merge this week!

@dlen dlen self-requested a review September 30, 2024 20:08
@andmich351
Copy link

Hey @dlen, would you maybe have some updates regarding merging this change?

@ngoduykhanh
Copy link

@dlen any news? I am looking forward to using this feature too 🙇

@dlen
Copy link
Member

dlen commented Oct 29, 2024

Sorry guys I had some other priorities these last few weeks. @Tecnobutrul is taking care of this and other PR to make a release ASAP.

@dlen dlen requested review from Tecnobutrul and removed request for dlen October 29, 2024 14:53
@passbolt-github passbolt-github merged commit 0bb0d25 into passbolt:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants