(PC-34203)[API] fix: enforce chronicle unicity even if typeform sends… #16011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 1128f17): https://pc-pro-testing--pr16011-pc-34203-rpa-chronic-bxc40gfm.web.app (expires Thu, 30 Jan 2025 14:01:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
rpaoloni-pass
force-pushed
the
pc-34203-rpa-chronicle_unicity
branch
from
9df6326 to
a794f78
Compare
rpaoloni-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
xordoquy-pass
approved these changes
Jan 24, 2025
prouzet-pass
approved these changes
Jan 24, 2025
| FROM | ||
| chronicle | ||
| WHERE | ||
| "formId"=c."formId" |
There was a problem hiding this comment.
Question/suggestion : serait-il pertinent, logique, de garder explicitement le premier créé ?
Suggested change
| "formId"=c."formId" | |
| "formId"=c."formId" | |
| ORDER BY id |
There was a problem hiding this comment.
en vrai on s'en fiche un peu, ils sont tous identiques, mais ça coûte pas grand chose de le faire
rpaoloni-pass
force-pushed
the
pc-34203-rpa-chronicle_unicity
branch
from
a794f78 to
cd4fb9f
Compare
rpaoloni-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
rpaoloni-pass
force-pushed
the
pc-34203-rpa-chronicle_unicity
branch
from
cd4fb9f to
1128f17
Compare
rpaoloni-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… it twice
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34203
Vérifications