Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32811)[API] feat: set update requests to without continuation eve… #15921

Conversation

vroullier-pass
Copy link
Contributor

…ry 30d

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32811

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques
  • J'ai fait la revue fonctionnelle de mon ticket

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Visit the preview URL for this PR (updated for commit 724da27):

https://pc-pro-testing--pr15921-pc-32811-set-update-hmyb0hik.web.app

(expires Sun, 26 Jan 2025 11:05:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

Copy link
Contributor

@prouzet-pass prouzet-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai rien testé en local.

api/src/pcapi/core/users/ds.py Outdated Show resolved Hide resolved
api/src/pcapi/core/users/ds.py Outdated Show resolved Hide resolved
api/src/pcapi/core/users/ds.py Outdated Show resolved Hide resolved
api/src/pcapi/core/users/ds.py Outdated Show resolved Hide resolved
api/src/pcapi/core/users/ds.py Outdated Show resolved Hide resolved
api/tests/core/users/test_ds.py Outdated Show resolved Hide resolved
@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch 2 times, most recently from 30a8bd6 to 0a17461 Compare January 22, 2025 14:06
@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch 2 times, most recently from 1e4b3d2 to 51cc01e Compare January 22, 2025 16:15
@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch from 51cc01e to 3f3f636 Compare January 23, 2025 17:19
@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch from 3f3f636 to e30a3a6 Compare January 24, 2025 08:54
@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch from e30a3a6 to f9dd2cc Compare January 24, 2025 10:32
Copy link
Contributor

@prouzet-pass prouzet-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revue fonctionnelle en "pair review" (VR + PR) :
Branche testée en environnement de développement connecté à DS (démarche de test) : OK 🟢

@vroullier-pass vroullier-pass force-pushed the PC-32811-set-update-requests-to-without-continuation-every-30d branch from f9dd2cc to 724da27 Compare January 24, 2025 11:03
@vroullier-pass vroullier-pass merged commit 16145ee into master Jan 24, 2025
27 of 28 checks passed
@vroullier-pass vroullier-pass deleted the PC-32811-set-update-requests-to-without-continuation-every-30d branch January 24, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants