Feature/tachyon flash config blob #791
Conversation
keeramis
force-pushed
the
feature/tachyon-flash-config-blob
branch
from
32e0630 to
b62a363
Compare
| async _flash({ files, skipFlashingOs, output }) { | ||
|
|
||
| const packagePath = files[0]; | ||
|
|
||
| const question = { |
There was a problem hiding this comment.
Will this question be asked if --load_config is passed? Remember the goal of load config is to have a setup without a single question. Andrew will use this in the Tachyon CI.
There was a problem hiding this comment.
This will still ask the question. Let me fix it.
There was a problem hiding this comment.
I removed this. There is another question about product. Is this something we want to put in the config file as well?
src/cmd/flash.js
Outdated
| const dir = await unzip.Open.file(zipPath); | ||
| const firehoseFile = dir.files.find(file => file.path.includes('firehose')); | ||
| if (!firehoseFile) { | ||
| throw new Error('Unable to find firehose file'); | ||
| } |
There was a problem hiding this comment.
The logic to find the firehose file is already present in _extractFlashFilesFromZip and is more precise: open the zip, load the manifest JSON, get the field for the firehose loader.
Call _extractFlashFilesFromZip and get the loader filename from the first element of the returned files. Then load that file from the zip.
keeramis
force-pushed
the
feature/tachyon-flash-config-blob
branch
from
0d19988 to
d4fdf2e
Compare
keeramis
force-pushed
the
feature/tachyon-flash-config-blob
branch
from
d4fdf2e to
9034d4f
Compare
Description
skip-resetcommand--skip_fashing_oscommand but flashing only the config.xml filesave_configwill save json file with config params exceptregistration_codeload_configloads the config file and adds the then generatedregistration_codeto create the config blob~in ssh pathqlril-appwithparticle-rilHow to Test
Related Issues / Discussions
Completeness