refactor: Parseable as the main interface
#1143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
reviewed
Feb 2, 2025
nitisht
reviewed
Feb 2, 2025
| // use the id that was generated/found in the staging and | ||
| // generate the path for the object store | ||
| let path = ingestor_metadata_path(None); | ||
| let path = meta.file_path(); | ||
|
|
||
| // we are considering that we can always get from object store | ||
| if let Some(mut store_data) = storage_ingestor_metadata { |
There was a problem hiding this comment.
test initialising multiple ingestors setup / delete ingestor for distributed
Co-authored-by: Nikhil Sinha <[email protected]> Signed-off-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Nikhil Sinha <[email protected]> Signed-off-by: Devdutt Shenoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Refactors code to share a
Parseableobject that is the interface to perform all operations in parseable, instead of having distinct interfaces such asCONFIG,StreamInfo, etc.This PR has: