[node_backup] Add support for other s3 providers #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @blakebyrnes, please sign the CLA here. |
nprt
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Hey @blakebyrnes, thanks again for taking the time to submit this PR!
I left a couple of comments. I'd love to hear your thoughts.
One last thing, could you, please, also change the version here: https://github.com/paritytech/ansible-polkadot/blob/main/galaxy.yml#L11? Once we bump the version there, it should publish the new release on Ansible Galaxy. We'll look into automating this in the future. |
You can configure another s3 provider by supplying the node_backup_s3_provider, node_backup_s3_access_key_id, node_backup_s3_secret_access_key, node_backup_s3_endpoint and optionally node_backup_s3_region. To use this type of service, you have to set the backup type to s3-rclone.
Restrict the no_check_bucket to Cloudflare as the impact on other sites is unknown. Also bumps galaxy.yml
nprt
approved these changes
Jan 9, 2025
|
Thank you for contribution 👍 |
BulatSaif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can configure another s3 provider by supplying the node_backup_s3_provider, node_backup_s3_access_key_id, node_backup_s3_secret_access_key, node_backup_s3_endpoint and optionally node_backup_s3_region. To use this type of service, you have to set the backup type to s3-rclone.
This change defaults to the previous configs (
node_backup_r2_access_key_id, etc and a Cloudflare s3 provider.