rofi-app: Add configuration editor prototype #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just uncommenting already existing code and making use of conditional compilation. Fixes the following warnings: Generic Warning: In /build/VTK-8.2.0/GUISupport/Qt/QVTKWidget.cxx, line 83 QVTKWidget was deprecated for VTK 8.1 and will be removed in a future version. Generic Warning: In /build/VTK-8.2.0/GUISupport/Qt/QVTKPaintEngine.cxx, line 25 QVTKPaintEngine was deprecated for VTK 8.1 and will be removed in a future version. This is not really necessary for running on 8.2 but will be useful when fixing build on 9.0.
Also fixes the runtime warnings but not the CMake warnings since those are harder to work around. I used QVTKOpenGLNativeWidget since unlike QVTKOpenGLStereoWidget (called QVTKOpenGLWidget in 8.2), it is called the same in 9.0 and it is also recommended. Though, to add to the confusion the native widget was actually called QVTKOpenGLWidget before 8.2 so maybe it was intended to be used in 08b7aee.
Render method should not be called on Renderer but RenderWindow according to VTK docs: https://stackoverflow.com/a/48578781/160386 https://vtk.org/doc/release/7.1/html/classvtkRenderer.html#adc877bbb1ff9a92e36146f7e379815d5 This change fixes QVTKOpenGLWidget/QVTKOpenGLNativeWidget/QVTKOpenGLStereoWidget not rendering the loaded configuration until user interaction happened.
Actions are convenient as they are decoupled from the object that triggers them, which will allow us to re-use them in a menu, for example. The move to toolbar is to make space for editing widgets.
It might have been disabled by “Show sphere” action.
At the moment, it only highlights an actor when an actor is clicked and jumps to a corresponding place in the configuration text. To remain compatible with VTK 7, we cannot use `vtkActor->GetProperty()->GetInformation()`, `vtkActor->GetPropertyKeys()` works but we need to make sure the `vtkInformation` objects exists.
Does not support adding new connections yet and is quite inefficient.
It is already autoconnected by the code generated by Qt’s uic (QMetaObject::connectSlotsByName).
|
Hi, do you have any progress? Please, let me know when I can test it and review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial prototype of the configuration editor. It allows selecting module parts by clicking them and then changing their angles using a Qt widget. Currently, it works by replacing the corresponding part of the configuration text (user still needs to press the Show button).
Additionally, this fixes few small bugs and enables building with VTK 9.
Next, I plan to work on UI for adding new modules and connections, showing the changes in real-time and modifying the
Configurationobject directly.