Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREAT-422 Stratus AWS S3 Detections #1528

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

THREAT-422 Stratus AWS S3 Detections #1528

wants to merge 6 commits into from

Conversation

akozlovets098
Copy link
Contributor

Changes

  • Added AWS.S3.SuspiciousFileActivities rule

Testing

pat test

@akozlovets098 akozlovets098 requested a review from a team as a code owner March 3, 2025 12:36
@arielkr256 arielkr256 added the rules Real-time log data detections label Mar 4, 2025
arielkr256
arielkr256 requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule likely needs to be split into 3 more specific rules for DeleteObject, DeleteObjects, and CopyObject.

rules/aws_cloudtrail_rules/aws_s3_suspicious_files_activities.py Outdated
Comment on lines 11 to 16
def rule(event):
return (
aws_cloudtrail_success(event)
and event.get("eventSource") == "s3.amazonaws.com"
and event.get("eventName") in SUSPICIOUS_EVENTS
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it would be overly noisy, especially since the rule has a threshold of 1. For DeleteObject I would expect a high threshold. For DeleteObjects a lower threshold. We are not interested in GetObject as that is a read only event and will be very noisy. For CopyObject we are only interested when the copied files are encrypted with a client-side key, and again this should have a high threshold.

@akozlovets098 akozlovets098 force-pushed the THREAT-422-Stratus-AWS-S3-Detections branch from 22bc8b4 to 3e4b9aa Compare March 7, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
rules Real-time log data detections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akozlovets098 @arielkr256 @panther-bot-automation