Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREAT-445 Stratus-GCP-Exfiltration #1527

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

THREAT-445 Stratus-GCP-Exfiltration #1527

wants to merge 3 commits into from

Conversation

akozlovets098
Copy link
Contributor

Changes

  • Added rules: GCP.Compute.IAM.Policy.Update, GCP.Compute.Snapshot.UnexpectedDomain, GCP.Project.ExternalUserOwnershipInvite
  • Updated GCP.IAM.CorporateEmail rule

Testing

  • pat test

@akozlovets098 akozlovets098 marked this pull request as ready for review March 3, 2025 12:36
@akozlovets098 akozlovets098 requested a review from a team as a code owner March 3, 2025 12:36
@arielkr256 arielkr256 added the rules Real-time log data detections label Mar 4, 2025
arielkr256
arielkr256 reviewed Mar 4, 2025
View reviewed changes
rules/gcp_audit_rules/gcp_iam_corp_email.py Outdated
@@ -1,5 +1,7 @@
from panther_base_helpers import deep_get

EXPECTED_DOMAIN = "@your-domain.tld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to infer the email domain from the source user, and alert when the email domain of the target user is different? Otherwise this rule will need a Configuration Required tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

rules/gcp_audit_rules/gcp_invite_external_user_as_owner.py Outdated
@@ -0,0 +1,29 @@
from panther_gcp_helpers import gcp_alert_context

EXPECTED_DOMAIN = "@your-domain.tld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to infer the email domain from the source user, and alert when the email domain of the target user is different? Otherwise this rule will need a Configuration Required tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

rules/gcp_audit_rules/gcp_snapshot_insert.py
@@ -0,0 +1,30 @@
from panther_gcp_helpers import gcp_alert_context

EXPECTED_DOMAIN = "@your-domain.tld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to infer the email domain from the source user, and alert when the email domain of the target user is different? Otherwise this rule will need a Configuration Required tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, because here we check the authentication info itself. I added the tag

@akozlovets098 akozlovets098 force-pushed the THREAT-445-Stratus-GCP-Exfiltration branch from 5a350cd to 7dd5b42 Compare March 7, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
rules Real-time log data detections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akozlovets098 @arielkr256 @panther-bot-automation