Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1 Threat Passthrough Tuning #1480

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

arielkr256
Copy link
Contributor

Background

S1 Threat Passthrough title was looking at fields that do not always exist in the logs, resulting in bad alert titles.

Changes

  • Updated title function to be more useful
  • Downgraded severity from CRITICAL/HIGH to HIGH/MEDIUM for malicious/suspicious threats

Testing

  • pat test

@arielkr256 arielkr256 requested a review from a team as a code owner January 17, 2025 16:57
@ben-githubs
Copy link
Contributor

@arielkr256 do you have any reference that these fields are always present and applicable? Our schema doesn't list them as required (they're inside a JSON blob). The only unit tests we have are for cases where a malicious file was detected, but I would imagine there are other kinds of alerts S1 could raise which aren't based on a specific file (and thus might not have a filedisplayname field)

@arielkr256 arielkr256 added the tuning detection tuning label Jan 24, 2025
@arielkr256
Copy link
Contributor Author

@ben-githubs I confirmed that the 4 activity types in this rule should always have computername and filedisplayname.

@ben-githubs ben-githubs enabled auto-merge (squash) January 28, 2025 21:00
@ben-githubs ben-githubs merged commit db177c9 into develop Jan 28, 2025
7 checks passed
@ben-githubs ben-githubs deleted the threat-433-s1-threat-tuning branch January 28, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tuning detection tuning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants