Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] GitHub Data Model Admin Actions update (#79) #1104

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Feb 13, 2024

Background

Updates GitHub data model to consider action = 'team.add_repository' and permission = 'admin' as an admin event for udm.assigned_admin_role and udm.get_event_type methods

Changes

  • Adds a CONDITIONAL_ADMIN_EVENTS variable that considers events as admin related when permission also equals "admin"

Testing

  • make test

@egibs egibs requested review from a team February 13, 2024 17:46
Copy link

github-actions bot commented Feb 13, 2024

😱
looks like somethings could be wrong with the packs

[ERROR][root]: There are packs that are potentially missing detections: auth0.yml: Auth0.MFA.Factor.Setting.Enabled aws.yml: AWS.UnusedRegion,AWS.Unsuccessful.MFA.attempt,AWS.Console.RootLogin,AWS.RDS.ManualSnapshotCreated,AWS.LAMBDA.CRUD,AWS.Software.Discovery carbonblack.yml: CarbonBlack.AlertV2.Passthrough cloudflare.yml: Cloudflare.HttpRequest.BotHighVolumeGreyNoise,Cloudflare.HttpRequest.BotHighVolume crowdstrike.yml: Okta.Login.From.CrowdStrike.Unmanaged.Device,OnePassword.Login.From.CrowdStrike.Unmanaged.Device,AWS.Authentication.From.CrowdStrike.Unmanaged.Device dropbox.yml: Dropbox.Many.Downloads,Dropbox.Many.Deletes gcp_audit.yml: GCP.compute.instances.create.Privilege.Escalation notion.yml: Notion.LoginFromBlockedIP okta.yml: Okta.Identity.Provider.SignIn
<!-- thollander/actions-comment-pull-request "check-packs" -->

* action = 'team.add_repository' and perm = 'admin'

* fmt

---------

Co-authored-by: Evan Gibler <[email protected]>
@egibs egibs enabled auto-merge (squash) February 13, 2024 18:28
@egibs egibs merged commit e60b7c7 into main Feb 13, 2024
6 checks passed
@egibs egibs deleted the egibs-sync-79 branch February 13, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants