Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sync] Remove Rules that require configuration or aren't enabled; update PAT… #1096

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[sync] Remove Rules that require configuration or aren't enabled; update PAT… #1096

merged 2 commits into from
Feb 8, 2024

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Feb 8, 2024

Background

Rules that have the Configuration Required Tag or that aren't turned on by default should not be in Packs.

This PR removes rules that match either (or both) of these criteria.

Changes

  • Removes rules from Packs that shouldn't be there

Testing

  • Tests pass as expected

@egibs egibs requested review from a team February 8, 2024 23:16
@egibs egibs enabled auto-merge (squash) February 8, 2024 23:34
@egibs egibs merged commit a126a0d into main Feb 8, 2024
6 checks passed
@egibs egibs deleted the egibs-sync-74 branch February 8, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egibs @arielkr256