Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hud-warning if protection_bypass is enabled #50

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

BuckarooBanzay
Copy link
Contributor

only for non-admins (players without "privs" priv)

screenshot_20220112_092353

only for non-admins (players without "privs" priv)
@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jan 12, 2022
@OgelGames
Copy link
Contributor

Good idea 👍 (text is slightly too far to the right though)

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2022

Seems somewhat good direct action to workaround existing problem but also something that should not be needed in first place.
Makes me wonder if there's some problem with said privilege use?

@BuckarooBanzay
Copy link
Contributor Author

Good idea +1 (text is slightly too far to the right though)

Uh, you're right, but it should be perfectly centered with { x=0.5, y=0.5 } 😕

Seems somewhat good direct action to workaround existing problem but also something that should not be needed in first place.
Makes me wonder if there's some problem with said privilege use?

The rationale is: protection_bypass can be granted for a limited time to trusted users (maybe with a proper "privilege elevation" command in lua-code instead of command blocks, just an idea)
To ensure that the priv gets revoked as soon as possible a "nagging" text should inform the player about the special condition.

Do you have an alternative suggestion for cleanups that require higher privileges?

@S-S-X
Copy link
Member

S-S-X commented Jan 12, 2022

Do you have an alternative suggestion for cleanups that require higher privileges?

Not for actual privileges / ways to carry out required actions but I think it would be good to have alternative way to drop privileges.

maybe with a proper "privilege elevation" command in lua-code instead of command blocks, just an idea

I mean this but not for gaining privileges, just for dropping privileges.
Command block is good as it requires player to actually move to control room to gain extra privileges but I think it would be a lot better to allow dropping privileges instantly without going to some specific location.
(having teleport ability or /control command does not really affect this, it is good to require extra "thing" as that makes people think twice if high privileges are really needed)

Chat command to drop privileges but not to gain privileges?
And also add that chat command to hud message.

To ensure that the priv gets revoked as soon as possible a "nagging" text should inform the player about the special condition.

Yeah, I think it is needed here... It probably is just that I do myself strongly believe in proper training / sharing knowledge so that people who have access to stuff requiring high privileges also completely understand why they have access, how to use privileges, how to not use privileges and why it is important to drop privileges as soon as possible.
While I would like that option very much I guess training like that is not really possible here...

@OgelGames
Copy link
Contributor

it should be perfectly centered with { x=0.5, y=0.5 } 😕

Maybe this value needs changing?

offset = {x=20, y=0},

@SwissalpS
Copy link
Contributor

I like this because a player might log off before going to /control to revoke his override priv and would instantly be aware that he still has it when he logs back on.

@BuckarooBanzay
Copy link
Contributor Author

Command block is good as it requires player to actually move to control room to gain extra privileges but I think it would be a lot better to allow dropping privileges instantly without going to some specific location.

how about an "expiration" timer for the priv plus chat-commands:
you can grant it to yourself with /protection_bypass_sudo and revoke it either with protection_bypass_drop or it will automatically be revoked on logout/after 10 minutes

@OgelGames
Copy link
Contributor

how about an "expiration" timer for the priv plus chat-commands

👍 Could probably use a single command to toggle it though (/protection_bypass)

@BuckarooBanzay BuckarooBanzay marked this pull request as draft January 20, 2022 19:35
@SwissalpS SwissalpS marked this pull request as ready for review January 2, 2025 15:00
@SwissalpS
Copy link
Contributor

LGTM as in: I don't mind details like being centered etc. as long as there is something for now. It might take another two years before somebody implements the ideas in this thread.

Have opened #85 so we don't forget.

@BuckarooBanzay
Copy link
Contributor Author

well then, i think i'm pushing the button on this one...

@BuckarooBanzay BuckarooBanzay merged commit 0f810e9 into master Jan 5, 2025
2 checks passed
@SwissalpS SwissalpS deleted the protection-bypass-warn branch January 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants