BUG/TST (string dtype): raise proper TypeError in interpolate #60637
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Testing
rhshadrach
changed the title
rhshadrach
commented
Dec 31, 2024
Comment on lines
88
to
89
| if not using_infer_string: | ||
| assert np.shares_memory(df["D"]._values, dvalues) |
There was a problem hiding this comment.
With EAs, I don't think there can be any expectation that this is holds.
There was a problem hiding this comment.
Suggested change
| if not using_infer_string: | |
| assert np.shares_memory(df["D"]._values, dvalues) | |
| assert tm.shares_memory(df["D"]._values, dvalues) |
If we use our own helper that can handle EAs, it actually still appears to be true
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Jan 2, 2025
Comment on lines
88
to
89
| if not using_infer_string: | ||
| assert np.shares_memory(df["D"]._values, dvalues) |
There was a problem hiding this comment.
Suggested change
| if not using_infer_string: | |
| assert np.shares_memory(df["D"]._values, dvalues) | |
| assert tm.shares_memory(df["D"]._values, dvalues) |
If we use our own helper that can handle EAs, it actually still appears to be true
mroeschke
approved these changes
Jan 3, 2025
|
Thanks @rhshadrach |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jan 3, 2025
…-dev#60637) * TST(string dtype): Resolve xfail for interpolate * Adjust arrow tests * Fixup for NumPyExtensionArray * Use tm.shares_memory (cherry picked from commit 5e50d3f)
|
Manual backport -> #60652 |
jorisvandenbossche
added a commit
that referenced
this pull request
Jan 3, 2025
…terpolate (#60637) (#60652) BUG/TST (string dtype): raise proper TypeError in interpolate (#60637) * TST(string dtype): Resolve xfail for interpolate * Adjust arrow tests * Fixup for NumPyExtensionArray * Use tm.shares_memory (cherry picked from commit 5e50d3f) Co-authored-by: Richard Shadrach <[email protected]>
gmcrocetti
pushed a commit
to gmcrocetti/pandas
that referenced
this pull request
Jan 3, 2025
…-dev#60637) * TST(string dtype): Resolve xfail for interpolate * Adjust arrow tests * Fixup for NumPyExtensionArray * Use tm.shares_memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.