ENH: Implement cum* methods for PyArrow strings #60633
Open
+161
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Enhancement
Strings
The only other way I think that would be reasonable to implement this in would be to use nanoarrow, but that's a larger implementation. I think this is fine for now - just not very performant but that can always be improved later |
rhshadrach
commented
Jan 1, 2025
| @@ -163,10 +166,10 @@ def test_agg_cython_table_transform_series(request, series, func, expected): | |||
| # GH21224 | |||
| # test transforming functions in | |||
| # pandas.core.base.SelectionMixin._cython_table (cumprod, cumsum) | |||
| if series.dtype == "string" and func == "cumsum": | |||
| if series.dtype == "string" and func == "cumsum" and not HAS_PYARROW: | |||
There was a problem hiding this comment.
Can tackle the StringArray case in a followup or do so here if preferred.
WillAyd
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Implements
cumsum,cummin, andcummaxfor PyArrow-backed strings. I don't see a way to do this without passing through NumPy - if there are other ideas for approaching happy to give those a shot.cc @WillAyd @jorisvandenbossche