Fix AARCH64 syscalls2 and OSI #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacraig2
force-pushed
the
fix_aarch64_syscalls
branch
from
a59f3c3 to
16678b9
Compare
| void aarch64_sbe(CPUState *cpu, TranslationBlock *tb) { | ||
| if (unlikely(panda_in_kernel_code_linux(cpu) && ((CPUARMState*) cpu->env_ptr)->sp_el[0] != 0)){ | ||
| aarch64_initialized = true; | ||
| spel0 = ((CPUARMState*) cpu->env_ptr)->sp_el[0]; |
There was a problem hiding this comment.
Would you be happier to have this logic in https://github.com/panda-re/panda/tree/dev/panda/plugins/hw_proc_id? We're doing something similar in there for mips - that way OSI itself isn't doing block-level analysis, just consuming the results of another analyses.
There was a problem hiding this comment.
I thought about that, but the frustrating part is that it's only enabled for kernels later than ~4.6. Additionally, it's not actually producing a hwid value like r28 is used in MIPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes assumptions in AARCH64 OSI and syscalls2.