Add new callback for QMP events #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFasano
force-pushed
the
qmp_cb
branch
3 times, most recently
from
54d08db to
9f8995f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no QEMU code is consuming a QMP event of type "execute" give panda a chance to jump in with the new
qmpcallback.I initially explored passing the QObject structures directly to PANDA but this forced our callback consumers to be able to parse a whole bunch of QObjects and related types that were quite painful to deal with (see the abandoned attempt at https://github.com/panda-re/panda/compare/qmp_cb2). Instead I just went with JSON.
It's not pretty but it works and there's an example.