Run ldconfig and add testing in CI #17
Open
+48
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewQuijano
force-pushed
the
master
branch
3 times, most recently
from
69a8805 to
482a02e
Compare
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
master
branch
7 times, most recently
from
c48bff5 to
a1b9cb9
Compare
|
Not sure where the dashes are coming from
|
|
Screenshots confirming build and install works as intended, updated README to work on whatever the libosi Debian package name is P. S.
|
AndrewQuijano
force-pushed
the
master
branch
2 times, most recently
from
fb6c712 to
ccfa70b
Compare
update CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think you still need to run
ldconfigafter installing libosi to use the shared libraries, so I might as well enforce this when running the Debian Package.Proof this works
https://github.com/AndrewQuijano/libosi/releases/tag/v0.0.1
https://github.com/AndrewQuijano/libosi/actions/runs/12458020130/job/34773177988
P. S. Adding Ubuntu 24, while the CI is SLOW, it seems to work?
https://github.com/AndrewQuijano/libosi/releases/tag/v0.0.5
Also, I slightly updated CMakeLists.txt to use later versions, no issues. Moreover, I updated how it installs to more properly align with Debian Packaging standards, so now
/usr/lib/is installed in/usr/lib/x86_64-linux-gnu, which is also required forldconfigto work correctly.libosi_files.txt