Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gravity gRPC client implementation #385

Merged
merged 7 commits into from
May 24, 2024

Conversation

byte-bandit
Copy link
Collaborator

@byte-bandit byte-bandit commented May 24, 2024

Background

The gRPC message sender implementation for gravity was never properly updated to work with multiple signing keys in Pigeon. This change adds the necessary changes to ensure all messages are sent with fee grant in mind.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes

@byte-bandit byte-bandit force-pushed the clohr/paloma-client-update branch from 5e7eb9e to 02069eb Compare May 24, 2024 09:36
@byte-bandit byte-bandit enabled auto-merge (squash) May 24, 2024 09:58
Copy link
Contributor

@maharifu maharifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byte-bandit byte-bandit merged commit d6934e1 into palomachain:master May 24, 2024
2 checks passed
@byte-bandit byte-bandit deleted the clohr/paloma-client-update branch May 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants