fix: avoid overly eager balance lookup #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
We see a lot of error logs when trying to verify validators balances on chains. This is because the established architecture allows to query at arbitrary times, even though Paloma always only uses the current time. The algorithm used to identify the closest block to the given time can lead to resulting in the latest block number, which might not be finalised yet.
For now, we just fall back to the
latest block number - 1
in this case, which should work. In the future, we might want to strip out the entire block height search and always use the current block height, as it's using binary search to approximate the block and makes a decent amount of API calls while doing so.Testing completed
Breaking changes