Skip to content

Commit

Permalink
clean readme
Browse files Browse the repository at this point in the history
  • Loading branch information
@webelf101
webelf101 committed Oct 18, 2022
1 parent d82d11c commit a84b3dc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ evm:
keyring-pass-env-name: ETH_PASSWORD
signing-key: ${ETH_SIGNING_KEY}
keyring-dir: ~/.pigeon/keys/evm/eth-main
gas-adjustment: 2 # will replace with hardcoded value (2) if txType is 2
tx-type: 2 # According to EIP-1559, Type(0x02) means EIP-1559 tx, Type(0x00) means legacy tx.
gas-adjustment: 2
tx-type: 2

bnb-main:
chain-id: 56
Expand All @@ -136,7 +136,7 @@ evm:
signing-key: ${BNB_SIGNING_KEY}
keyring-dir: ~/.pigeon/keys/evm/bnb-main
gas-adjustment: 1
tx-type: 0 # omitting or any values except 2 works as 0 (legacy tx)
tx-type: 0
```
Expand Down

4 comments on commit a84b3dc

@taariq
Copy link
Contributor

@taariq taariq commented on a84b3dc Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we make this change?

@webelf101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#72 (comment)

@webelf101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@measure-fi suggested moving the comment into golang code. But I couldn't find any comments similar to it in golang code. So I removed it only.

@webelf101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I already put similar comments in golang code.

Please sign in to comment.