fix: prevent mapping multiple denoms to same ERC20 #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taariq
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
This change adds a check that prevents binding a
denomto an ERC20 address that is already bound.Important
This will prevent updating your ERC20 addresses against your own denoms even, but it could theoretically be implemented at a later stage.
Warning
The underlaying gravity bridge code was not written with more than one remote chain in mind. Therefore, after this change, it will not be possible to use the same Ethereum address for a denom on more than one remote chain, so deterministic addresses cannot be used anymore.
Testing completed
Breaking changes