Skip to content

Commit

Permalink
Merge branch '3.0.x'
Browse files Browse the repository at this point in the history
  • Loading branch information
davidism committed Feb 3, 2024
2 parents 94e80b3 + d5e321b commit 6b422a0
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 3 deletions.
10 changes: 10 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
Version 3.0.2
-------------

Released 2024-02-03

- Correct type for ``jinja_loader`` property. :issue:`5388`
- Fix error with ``--extra-files`` and ``--exclude-patterns`` CLI options.
:issue:`5391`


Version 3.0.1
-------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "Flask"
version = "3.0.1"
version = "3.0.2"
description = "A simple framework for building complex web applications."
readme = "README.rst"
license = {file = "LICENSE.rst"}
Expand Down
4 changes: 3 additions & 1 deletion src/flask/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,9 @@ def convert(
self, value: t.Any, param: click.Parameter | None, ctx: click.Context | None
) -> t.Any:
items = self.split_envvar_value(value)
return [super().convert(item, param, ctx) for item in items]
# can't call no-arg super() inside list comprehension until Python 3.12
super_convert = super().convert
return [super_convert(item, param, ctx) for item in items]


@click.command("run", short_help="Run a development server.")
Expand Down
3 changes: 2 additions & 1 deletion src/flask/sansio/scaffold.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from functools import update_wrapper

import click
from jinja2 import BaseLoader
from jinja2 import FileSystemLoader
from werkzeug.exceptions import default_exceptions
from werkzeug.exceptions import HTTPException
Expand Down Expand Up @@ -272,7 +273,7 @@ def static_url_path(self, value: str | None) -> None:
self._static_url_path = value

@cached_property
def jinja_loader(self) -> FileSystemLoader | None:
def jinja_loader(self) -> BaseLoader | None:
"""The Jinja loader for this object's templates. By default this
is a class :class:`jinja2.loaders.FileSystemLoader` to
:attr:`template_folder` if it is set.
Expand Down
5 changes: 5 additions & 0 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -679,3 +679,8 @@ def test_cli_empty(app):

result = app.test_cli_runner().invoke(args=["blue", "--help"])
assert result.exit_code == 2, f"Unexpected success:\n\n{result.output}"


def test_run_exclude_patterns():
ctx = run_command.make_context("run", ["--exclude-patterns", __file__])
assert ctx.params["exclude_patterns"] == [__file__]

0 comments on commit 6b422a0

Please sign in to comment.