Feauture filter out voided records in intermediate pregnant and breast feeding

[Marymary-dev]

Summary by Sourcery

Bug Fixes:

• Fixes an issue where voided records were not being filtered out in the intermediate pregnant and breast feeding tables.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request filters out voided records in the intermediate pregnant and breastfeeding tables. This is done by adding voided=0 to the where clause when selecting pregnant patients and by adding visit.voided=0 and pat.voided=0 to the where clause when selecting breastfeeding patients.

Sequence diagram for retrieving pregnant patients

sequenceDiagram
  participant DB as Database
  participant Query as Query

  Query->>DB: SELECT * FROM CT_PatientVisits WHERE Pregnant='Yes' AND LMP is not null AND voided=0 AND VisitDate <= @as_of_date
  DB-->>Query: Returns pregnant patients

Loading

Sequence diagram for retrieving breastfeeding patients

sequenceDiagram
  participant DB as Database
  participant Query as Query

  Query->>DB: SELECT * FROM CT_PatientVisits as visit LEFT JOIN CT_Patient as pat ON pat.PatientPK=visit.PatientPK AND pat.SiteCode=visit.SiteCode WHERE Breastfeeding='Yes' AND pat.voided=0 AND visit.voided=0 AND VisitDate <= @as_of_date
  DB-->>Query: Returns breastfeeding patients

Loading

File-Level Changes

Change	Details	Files
Added voided=0 to filter out voided records when selecting pregnant patients.	Added voided=0 to the where clause to filter out voided records.	Scripts/ODS/load_intermediate_tables/CT_intermediate_tables/Load_Intermediate_PregnantAndBreastFeeding.sql
Added visit.voided=0 and pat.voided=0 to filter out voided records when selecting breastfeeding patients.	Added visit.voided=0 to the where clause to filter out voided records from the visits table. Added pat.voided=0 to the where clause to filter out voided records from the patient table.	Scripts/ODS/load_intermediate_tables/CT_intermediate_tables/Load_Intermediate_PregnantAndBreastFeeding.sql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Marymary-dev - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like you're filtering out voided records in multiple CTEs - can you consolidate this logic into a single CTE or function to avoid repetition?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}